Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise error if metaflow_extension's Distribution#files is None. #2091

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Don't raise error if metaflow_extension's Distribution#files is None. #2091

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b259c4c
Don't raise error if metaflow_extension plugin with None files is
trhodeos Oct 9, 2024
71bb19e
Add log message
trhodeos Oct 15, 2024
d3050f4
TODO
trhodeos Oct 15, 2024
95edd84
fix
trhodeos Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion metaflow/extension_support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,13 @@ def _get_extension_packages(ignore_info_file=False, restrict_to_directories=None
# contributes to. This is to enable multiple namespace packages to contribute
# to the same extension point (for example, you may have multiple packages
# that have plugins)
for f in dist.files:
if not dist.files:
# TODO: fallback on iterating through the package if file metadata is not included
_ext_debug(
"Invalid package seen '%s' at '%s': no file list found in metadata"
% (dist_name, dist_root)
)
for f in dist.files or []:
parts = list(f.parts)

if len(parts) > 1 and parts[0] == EXT_PKG:
Expand Down
Loading