Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to get ILoadBalancer by name and instance of IClientConfig #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Savonitar
Copy link

Hi everybody!
I'd like to get ILoadBalancer by providing the name and IClientConfig instance. Currently we only have a way with Class<? extends IClientConfig> and in this case we will create an instance via newInstance() method.
But I need to provide the clientconfig instance created by myself, because it could be created with some additional parameters, could be configured in a special way (especially when i have to provide some parameters dynamically). In other words I need to provide the prepared IClientConfig instance instead of creation a new one.
Also I want to return an existed loadbalancer (if it exists), that's why I can't use registerNamedLoadBalancerFromclientConfig method because it throws an exception if the balancer exists.
Currently I use reflection to get an access to namedLBMap to get balancer by name and call registerNamedLoadBalancerFromclientConfig if it doesn't exist.

I can provide more details if it is required.
Looking forward to your answers! Thanks!

@Savonitar
Copy link
Author

Hi! Just a little friendly reminder.
Can we merge it? Or if you have some concern, we can discuss it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant