Skip to content

Commit

Permalink
Remove inflight metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
annieyang committed Nov 14, 2024
1 parent 38fbaf7 commit a665f79
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 50 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -265,35 +265,6 @@ public enum IpcMetric {
IpcTagKey.statusDetail
),
EnumSet.noneOf(IpcTagKey.class)
),

/**
* V2 - Number of outbound requests that are currently in flight.
*/
apiClientInflight(
"api.client.inflight",
EnumSet.of(
IpcTagKey.vip,
IpcTagKey.method,
IpcTagKey.endpoint,
IpcTagKey.owner,
IpcTagKey.id
),
EnumSet.noneOf(IpcTagKey.class)
),

/**
* V2 - Number of inbound requests that are currently in flight.
*/
apiServerInflight(
"api.server.inflight",
EnumSet.of(
IpcTagKey.method,
IpcTagKey.endpoint,
IpcTagKey.owner,
IpcTagKey.id
),
EnumSet.noneOf(IpcTagKey.class)
);

private final String metricName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,17 +268,6 @@ public void validateApiIdOk() {
IpcMetric.apiClientCall.validate(id, true);
}

@Test
public void validateApiInflightOk() {
Id id = registry.createId(IpcMetric.apiClientInflight.metricName())
.withTag(IpcTagKey.owner.tag("test"))
.withTag(IpcTagKey.vip.tag("localhost"))
.withTag(IpcMethod.get)
.withTag(IpcTagKey.endpoint.tag("hello"))
.withTag(IpcTagKey.id.tag("HelloEndpoint"));
IpcMetric.apiClientInflight.validate(id, true);
}

@Test
public void validateApiServerIdOk() {
Id id = registry.createId(IpcMetric.apiServerCall.metricName())
Expand All @@ -292,14 +281,4 @@ public void validateApiServerIdOk() {
.withTag(IpcTagKey.statusDetail.tag("200"));
IpcMetric.apiServerCall.validate(id, true);
}

@Test
public void validateApiServerInflightOk() {
Id id = registry.createId(IpcMetric.apiServerInflight.metricName())
.withTag(IpcTagKey.owner.tag("test"))
.withTag(IpcMethod.get)
.withTag(IpcTagKey.endpoint.tag("hello"))
.withTag(IpcTagKey.id.tag("HelloEndpoint"));
IpcMetric.apiServerInflight.validate(id, true);
}
}

0 comments on commit a665f79

Please sign in to comment.