[configuration] Make cmake configuration fail early upon boost or openBLAS installation failure #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: This PR introduces a couple of checks for the
cmake
configuration process to make it fail upon the installation failure of eitherboost
oropenblas
.Problem
At the moment, whenever any
tools/download_*.sh
script fails, the configuration process continues w/o any explicit message, for failing only at the end. This may surprise and mislead the (non-dev) user: issue #481 seems to be an example of that.Catching the erratic state of the configuration and fail early seems a better strategy to me.
Proposed solution
tools/download_*.sh
exit on any failure by passing the-e
to/bin/bash
CMakeLists.txt
and fail accordingly.Let me know what you think.