Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate successful conversions from drafts #54

Closed
wants to merge 3 commits into from

Conversation

garrettmflynn
Copy link
Member

This PR changes the rendering of successful / completed conversions on the main Getting Started page so that successful conversions are distinguished from drafted ones.

A few cosmetic changes are also added to the page to align it with NWB GUIDE rather than SODA.

@garrettmflynn garrettmflynn self-assigned this Mar 21, 2023
@garrettmflynn garrettmflynn changed the base branch from main to run-conversion March 21, 2023 19:58
Base automatically changed from run-conversion to main March 23, 2023 16:49
@CodyCBakerPhD
Copy link
Collaborator

I'm still not crazy about classifying a pipeline as being 'done' at any point

It's so common to want to rerun on a new batch of files, or even reupload to DANDI

Don't get me wrong, we should definitely have some kind of history or log that keeps track of what pipelines were completed and how they were run, but it doesn't have to become a state of the pipeline itself

@garrettmflynn
Copy link
Member Author

Yeah, that makes sense. This is why I've tried to separate pipeline design, pipeline runs, and DANDI uploads in #58.

In that case, there'd only be validated / approved pipelines that have gone through the entire design process—which are always able to be revised or run on different data.

Is there anything about the wording you'd like me to change right now?

@CodyCBakerPhD
Copy link
Collaborator

Is there anything about the wording you'd like me to change right now?

TBH the only classification I'd give is 'in progress' to indicate a pipeline is not complete (complete meaning only that they are past the metadata form step, not that they hit the 'run' button)

@CodyCBakerPhD
Copy link
Collaborator

Maybe we should mock it up a little bit in Figma first - putting this into draft until then

@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft March 23, 2023 18:02
@CodyCBakerPhD
Copy link
Collaborator

Can you draft a small mockup for this? I'm envisioning that the existing pipelines looks exactly as it does now except any pipeline that didn't hit the 'run conversion' button is flagged as 'in progress'

The history tracker is probably a separate feature altogether and can be put in a different place in the app too

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn Should we keep this open, move to an issue, or close?

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Jun 14, 2023

If we don't really want this separation (at least for now), we can just close it.

Otherwise we open a new Issue that clearly defines how we'd want a separation between existing conversions and completed conversions to look.

@CodyCBakerPhD
Copy link
Collaborator

Otherwise we open a new Issue that clearly defines how we'd want a separation between existing conversions and completed conversions to look.

That would be ideal

@CodyCBakerPhD CodyCBakerPhD deleted the transfer-completed-conversions branch June 14, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants