Add retry method for iTunes API requests #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes special characters cutting off the rest of the string
- Added try-catch block in the `main` function to handle connection errors, ensuring the connection is properly closed and attempting reconnection after a delay. - Implemented a `fetchWithTimeout` function to handle potential delays when fetching data from the iTunes API, improving reliability. - Updated `_getTrackExtras` to use the new `fetchWithTimeout` for API requests, including error logging on failure.
- Removed timeout from fetch - Added using MB for a fallback if the iTunes API is unavailable
This adds a method to retry the iTunes API request up to 3 times. For whatever reason, the API will sometimes fail and return a "Service Unavailable" error but will go through on the second attempt.
This reverts commit 6d3bec4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! It's me again 😅
This PR just adds an enhancement to my last one. This will attempt to hit the iTunes API up to 3 times if it fails before falling back to MusicBrainz for artwork.
I'm still trying to get to the bottom of why the iTunes API will sometimes return "Service Unavailable", but after some tests it does seem to go through on the second attempt each time it happens.