Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --allow-import to shebang #108

Closed
wants to merge 1 commit into from

Conversation

littledivy
Copy link

Running music-rpc.ts using launch agent fails with Deno 2 RC versions because of the new --allow-import permission.

$ deno -V
deno 2.0.0-rc.9
error: Requires import access to "win32.deno.dev:443", run again with the --allow-import flag
    at https://deno.land/x/[email protected]/deps.ts:1:21

@NextFire
Copy link
Owner

NextFire commented Oct 2, 2024

It looks like it breaks current v1 (retro-)compatibility (unexpected argument). Is there any solution for that?

I guess we also need to update the flags for the compile job:

flags: --allow-env --allow-run --allow-net --allow-read --allow-write --unstable-ffi --allow-ffi --unstable-kv

P.S.: I see you are also a Deno maintainer, would it be possible to ask you for help with #88 ?

@NextFire NextFire mentioned this pull request Oct 10, 2024
@NextFire
Copy link
Owner

Done in #109

@NextFire NextFire closed this Oct 10, 2024
@littledivy
Copy link
Author

Thanks for fixing!

P.S.: I see you are also a Deno maintainer, would it be possible to ask you for help with #88 ?

Yup, I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants