Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix un-catched exception #120

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Fix un-catched exception #120

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
291822c
Fix small issues
Kile Dec 18, 2024
eea2087
Revert command like change
Kile Dec 19, 2024
d4d8301
Abstract logic into method
Kile Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions music-rpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,13 @@ class AppleMusicDiscordRPC {
} finally {
// Ensure the connection is properly closed
if (this.rpc.ipc) {
console.log("Closing connection to Discord RPC");
this.rpc.close();
this.rpc.ipc = undefined;
console.log("Attempting to close connection to Discord RPC");
try {
this.rpc.close();
} finally {
console.log("Connection to Discord RPC closed");
this.rpc.ipc = undefined;
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract this block to something like this.tryCloseRPC() to avoid having too many nested statements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also put the if statement in that method, let me know if you want it to take it out again

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, LGTM

}
}
Expand Down