Skip to content

Commit

Permalink
fix: add --exclusive option to the deployment (#14)
Browse files Browse the repository at this point in the history
When building pipelines, the pipelines themselves handle the ordering of
resource deps... so we don't need to _re-run_ the deploy to a stack that
is a dependency of a current stack, we can trust that it was deployed
already.

Co-authored-by: Matt Wise <[email protected]>
  • Loading branch information
diranged and diranged authored Jan 23, 2024
1 parent 0dfb2dc commit 94171ad
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 6 deletions.
11 changes: 11 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"files.exclude": {
"**/.git": true,
"**/.svn": true,
"**/.hg": true,
"**/CVS": true,
"**/.DS_Store": true,
"**/Thumbs.db": true,
"**/node_modules": true
}
}
4 changes: 4 additions & 0 deletions src/pipeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ export class GitHubWorkflow extends PipelineBase {
this.runner = props.runner ?? github.Runner.UBUNTU_LATEST;
this.buildRunner = props.buildRunner ?? this.runner;

/** By default, deploy! */
this.deployArgs.push(`--require-approval=${props.requireApproval ?? 'never'}`);

/** The pipeline handles dependency ordering, no need to re-deploy dependency stacks */
this.deployArgs.push('--exclusively');
}

/**
Expand Down
14 changes: 10 additions & 4 deletions test/__snapshots__/github.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/__snapshots__/runner-provided.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion test/__snapshots__/stage-options.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 94171ad

Please sign in to comment.