Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stock 검색 작업 및 tickers 데이터 핸들링 #10

Merged
merged 18 commits into from
Feb 23, 2024
Merged

feat: stock 검색 작업 및 tickers 데이터 핸들링 #10

merged 18 commits into from
Feb 23, 2024

Conversation

JinleeJeong
Copy link
Member

@JinleeJeong JinleeJeong commented Feb 21, 2024 •
edited
Loading

Issue Number

close: #7

작업 내역

구현 내용 및 작업 했던 내역

  • 백엔드 API stock search를 통해 디바운싱 처리
  • 스토어를 통해 Stocks 데이터 생성/삭제/수정 작업
  • 토스트 뜨는 작업 (데이터 삭제 / 데이터 15개 이상)
  • �데이터 15개 이상에는 팝업을 띄워야 함
  • API 전송까지 완료

변경사항

  • 의존성 목록

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 스텀 훅 내부에서 생성된 Api 함수들을 호출하는 패턴 사용

Checklist

PR 등록 전 확인할 점

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat(user): add login page)
  • assignee가 본인으로 되어있고, label은 PR 주제에 맞게 추가했는가
  • description에 PR에 대해 구체적으로 설명했는가

@JinleeJeong JinleeJeong self-assigned this Feb 21, 2024
@JinleeJeong JinleeJeong marked this pull request as ready for review February 21, 2024 14:57
Bokdol11859
Bokdol11859 previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Bokdol11859 Bokdol11859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주로 사용하시는 스택과 �달라서 힘드셨을텐데 수고 많으셨습니다!!

src/api/http.ts Outdated Show resolved Hide resolved
src/app/(main)/ticker/_components/intro.tsx Outdated Show resolved Hide resolved
src/app/(main)/ticker/_components/intro.tsx Outdated Show resolved Hide resolved
src/app/(main)/ticker/_components/ticker-content.tsx Outdated Show resolved Hide resolved
src/app/(main)/ticker/_components/ticker-drawer.tsx Show resolved Hide resolved
src/state/queries/use-stocks.ts Outdated Show resolved Hide resolved
src/app/(main)/ticker/_components/selected-ticker-list.tsx Outdated Show resolved Hide resolved
src/state/queries/use-stocks-sector-ratio.ts Show resolved Hide resolved
src/app/(main)/ticker/_components/ticker-footer.tsx Outdated Show resolved Hide resolved
src/app/(main)/ticker/_components/ticker-footer.tsx Outdated Show resolved Hide resolved
Bokdol11859
Bokdol11859 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Bokdol11859 Bokdol11859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@JinleeJeong JinleeJeong merged commit 2af075c into main Feb 23, 2024
@JinleeJeong JinleeJeong deleted the feat/search-data-server branch February 23, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bokdol11859 Bokdol11859 Bokdol11859 approved these changes

Assignees

@JinleeJeong JinleeJeong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

주식 종목 입력 화면 작업 - Data
2 participants
@JinleeJeong @Bokdol11859