Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: apply qa review on stock detail #28

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Conversation

JinleeJeong
Copy link
Member

Issue Number

close: #

작업 내역

구현 내용 및 작업 했던 내역

  • stock detail QA 작업입니다.
  • 작업 내역 2

변경사항

  • 의존성 목록

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 특이 사항 1
  • 특이 사항 2

Checklist

PR 등록 전 확인할 점

  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat(user): add login page)
  • assignee가 본인으로 되어있고, label은 PR 주제에 맞게 추가했는가
  • description에 PR에 대해 구체적으로 설명했는가

@JinleeJeong JinleeJeong self-assigned this Feb 24, 2024
@JinleeJeong
Copy link
Member Author

@Bokdol11859
refactor: apply gray to grey

gray로 사용하는 것들이 있어서 다 grey로 치환했습니다!

Base automatically changed from feat/qa-landing-page to main February 24, 2024 18:53
@JinleeJeong
Copy link
Member Author

얘도 따로 리뷰할게 없어서 머지하겠습니다 !

@JinleeJeong JinleeJeong merged commit b4b5d54 into main Feb 24, 2024
@JinleeJeong JinleeJeong deleted the feat/qa-stock-detail branch February 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant