added expected fee change

Nexus-2023 · Jan 25, 2024 · 33dd40d · 33dd40d
1 parent d2ae701
commit 33dd40d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -24,4 +24,5 @@ cache
 .env
 contracts/proxy_test
 scripts/proxy_deploy.ts
-contracts/demo_contracts/delegate_test
+contracts/demo_contracts/delegate_test
+test/delegate_test.ts
diff --git a/contracts/nexus_bridge/NexusBridgeDAO.sol b/contracts/nexus_bridge/NexusBridgeDAO.sol
@@ -25,7 +25,8 @@ abstract contract NexusBridgeDAO is NexusBaseBridge {
         validatorCount -= 1;
     }
 
-    function redeemRewards(address reward_account) external onlyDAO validNexusFee(NexusFeePercentage){
+    function redeemRewards(address reward_account,uint256 expectedFee) external onlyDAO validNexusFee(NexusFeePercentage){
+        if(expectedFee!=NexusFeePercentage) revert IncorrectNexusFee();
         uint256 total_rewards = getRewards();
         if(total_rewards > VALIDATOR_DEPOSIT) revert WaitingForValidatorExits();
         uint256 _nexus_rewards = (NexusFeePercentage*total_rewards)/BASIS_POINT;

diff --git a/contracts/nexus_bridge/nexusLibrary.sol b/contracts/nexus_bridge/nexusLibrary.sol
@@ -144,13 +144,12 @@ contract NexusLibrary {
             slashedAmount;
     }
 
-    function redeemRewards(
-        address reward_account
-    ) external onlyDAO validNexusFee(getVariable(NEXUS_FEE_PERCENTAGE_SLOT)) {
+    function redeemRewards(address reward_account,uint256 expectedFee) external onlyDAO validNexusFee(getVariable(NEXUS_FEE_PERCENTAGE_SLOT)) {
+        uint256 NexusFeePercentage = getVariable(NEXUS_FEE_PERCENTAGE_SLOT);
+        if(expectedFee!=NexusFeePercentage) revert IncorrectNexusFee();
         uint256 total_rewards = getRewards();
         if (total_rewards > VALIDATOR_DEPOSIT)
             revert WaitingForValidatorExits();
-        uint256 NexusFeePercentage = getVariable(NEXUS_FEE_PERCENTAGE_SLOT);
         uint256 _nexus_rewards = (NexusFeePercentage * total_rewards) /
             BASIS_POINT;
         (bool nexus_success, bytes memory nexus_data) = NEXUS_FEE_ADDRESS.call{