Merge pull request #15 from Nexus-2023/audit_fixes

removed additional checks
Nexus-2023 · Jan 25, 2024 · b4a7080 · b4a7080
2 parents 30388e8 + bc74767
commit b4a7080
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/contracts/nexus_bridge/NexusBridgeDAO.sol b/contracts/nexus_bridge/NexusBridgeDAO.sol
@@ -25,7 +25,7 @@ abstract contract NexusBridgeDAO is NexusBaseBridge {
         validatorCount -= 1;
     }
 
-    function redeemRewards(address reward_account,uint256 expectedFee) external onlyDAO validNexusFee(NexusFeePercentage){
+    function redeemRewards(address reward_account,uint256 expectedFee) external onlyDAO{
         if(expectedFee!=NexusFeePercentage) revert IncorrectNexusFee();
         uint256 total_rewards = getRewards();
         if(total_rewards > VALIDATOR_DEPOSIT) revert WaitingForValidatorExits();

diff --git a/contracts/nexus_bridge/nexusLibrary.sol b/contracts/nexus_bridge/nexusLibrary.sol
@@ -144,7 +144,7 @@ contract NexusLibrary {
             slashedAmount;
     }
 
-    function redeemRewards(address reward_account,uint256 expectedFee) external onlyDAO validNexusFee(getVariable(NEXUS_FEE_PERCENTAGE_SLOT)) {
+    function redeemRewards(address reward_account,uint256 expectedFee) external onlyDAO {
         uint256 NexusFeePercentage = getVariable(NEXUS_FEE_PERCENTAGE_SLOT);
         if(expectedFee!=NexusFeePercentage) revert IncorrectNexusFee();
         uint256 total_rewards = getRewards();