Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: electron v30, forge, vite, biomejs, arm builds #536

Merged
merged 60 commits into from
Apr 22, 2024

Conversation

jgresham
Copy link
Member

@jgresham jgresham commented Apr 4, 2024

#457
#456
And gets us off of a slowly fading set of build tools and onto the new and official electron dev, build, and publishing tools

with Vite replacing Webpack, we should see much faster dev environments too

  • build and tests
  • forge indescriptive make fail blocking Error during packaging on macOS electron/forge#3549
  • package and publish
  • github actions
  • auto-updater
  • deep clean
  • storybook vite
  • e2e tests
  • switched to ESM modules as default (electron 28 started official support)

the only now outdated tool is typescript 4.5 instead of 5.x but many projects and starter templates are on 4.5, so not upgrading at this time. Not sure why projects are not using 5.x yet

  • auto-update plan from NN v5?

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for nndesign ready!

Name Link
🔨 Latest commit 278e53b
🔍 Latest deploy log https://app.netlify.com/sites/nndesign/deploys/6626b7cc21b2b50008da6775
😎 Deploy Preview https://deploy-preview-536--nndesign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgresham jgresham changed the title chore: electron forge and enables electron v29+ chore: electron v30, forge, vite, biomejs, arm builds Apr 22, 2024
@jgresham jgresham merged commit 4b7d308 into main Apr 22, 2024
16 checks passed
@jgresham jgresham deleted the chore/electron-forge-and-29 branch April 22, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant