Fix crash when starting from non ASCII path #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickelony
reviewed
Dec 30, 2024
| @@ -8,9 +8,10 @@ | |||
| <OutputType>WinExe</OutputType> | |||
| <RootNamespace>UniversalTombLauncher</RootNamespace> | |||
| <AssemblyName>launch</AssemblyName> | |||
| <TargetFrameworkVersion>v4.0</TargetFrameworkVersion> | |||
| <TargetFrameworkVersion>v4.8</TargetFrameworkVersion> | |||
There was a problem hiding this comment.
We cannot upgrade the version to 4.8 as this launcher is intended to work on systems as far back as Windows XP and on Windows 7 without having to manually install .NET 4, as it comes preinstalled with the system.
This fixes a crash that occurs when the launcher is started from a folder whose absolute path does contain non ASCII characters. This was due to the use of the WshRuntimeLibrary (a wrapper around COM libraries) that does not handle Unicode (as far as my deductions go). When assigning the target path to the shortcut object, the runtime would error. This commit replaces the WshRuntimeLibrary with a COM wrapper around the IShellLink interface, using its Unicode oriented functions. The WshRuntimeLibrary is removed from dependencies and the .NET framework is updated to 4.8 as 4.0 has reached EOL. Tested on: Win10 64-bits.
Sylmir
force-pushed
the
sylmir/fix_shortcut_unicode
branch
from
036e218 to
37d1176
Compare
|
Updated. Windows won't let me install .NET 4.0 because I already have 4.8 (or later) installed, so I cannot check for sure if it even builds, hope for the best (it built and ran successfully with 4.8, I don't think there's any reason it wouldn't build or run with 4.0, but who knows...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash that occurs when the launcher is started from a folder whose absolute path does contain non ASCII characters. This was due to the use of the WshRuntimeLibrary (a wrapper around COM libraries) that does not handle Unicode (as far as my deductions go). When assigning the target path to the shortcut object, the runtime would error.
This commit replaces the WshRuntimeLibrary with a COM wrapper around the IShellLink interface, using its Unicode oriented functions.
The WshRuntimeLibrary is removed from dependencies and the .NET framework is updated to 4.8 as 4.0 has reached EOL.
Tested on: Win10 64-bits.
Warning: The code is taken from https://stackoverflow.com/a/14632782 As you can see from the comments, some people argue this does not work on all versions of Windows, possibly something tied to 32 / 64 bits. Further testing on other Win versions and archs is probably required