zib MultidisciplinaryTeamMeeting #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing nl-core-profiles |
Validation report for changed materialsValidation
Zib compliance
|
Validation report for changed materialsValidation
Zib compliance
|
Validation report for changed materialsValidation
Zib compliance
|
Validation report for changed materialsValidation
Zib compliance
|
Validation report for changed materialsValidation
Zib compliance
|
Validation report for changed materialsValidation
Zib compliance
|
|
Gave this one an update. Still 2 zib compliance errors that I feel are uncorrect (see above): ==== snapshots/zib-MultidisciplinaryTeamMeeting.json BackboneElement instead of container is #76 |
…TeamMeeting # Conflicts: # known-issues.yml
Validation report for changed materialsValidation
Zib compliance
|
Validation report for changed materialsValidationZib compliance
|
|
Looks good! Regarding the 2 zib compliance errors: one has been solved in the tooling, the other one about conceptual cardinalities should be solved in the tooling too. Created #187 for this. |
LuudSlagter
approved these changes
Nov 8, 2021
Validation report for changed materialsValidation
Zib compliance
|
LilianMinne
reviewed
Jan 14, 2022
LilianMinne
reviewed
Jan 14, 2022
LilianMinne
reviewed
Jan 14, 2022
LilianMinne
reviewed
Jan 14, 2022
LilianMinne
reviewed
Jan 14, 2022
LilianMinne
reviewed
Jan 14, 2022
Validation report for changed materialsValidation
Zib compliance
|
…tationLabel from extension to type.text. Moved code from .type to .class.
Validation report for changed materialsValidation
Zib compliance
|
…so that it is no longer specifically about zib-Patient but about the Patient resource in general.
pieter-edelman-nictiz
force-pushed
the
zib-MultidisciplinaryTeamMeeting
branch
from
d3a6262
to
29d4d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do: but not by me I guess
release-notes? New zib so I don't know if that is necessary
known-issues:
==== snapshots/zib-MultidisciplinaryTeamMeeting-CarePlan.json
== NL-CM:15.2.12 (CarePlan.activity.reference)
cardinality: ERROR (0..1 instead of 0..)
==== snapshots/zib-MultidisciplinaryTeamMeeting.json
== NL-CM:15.2.13 (Encounter.participant)
datatype: ERROR (BackboneElement instead of container)
cardinality: ERROR (0.. instead of 1..*)
First one (CarePlan.activity.reference) can be silenced, because .activity has 0..* resulting in that effective cardinality
BackboneElement instead of container is #76
Cardinality 0..* instead of 1..* is the issue in zib validation tooling as I mentioned yesterday. zib cardinality is 2..* , the tooling makes it a conceptual 1..* , but I feel it should be 0..*. No ticket made yet.
Besides this a normal review can be done