chore: fix spotbugs

Nike-Inc · Dec 18, 2019 · d8eeb89 · d8eeb89
1 parent 83e2b31
commit d8eeb89
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/.../src/main/java/com/nike/cerberus/controller/authentication/AwsIamKmsAuthV1Controller.java b/.../src/main/java/com/nike/cerberus/controller/authentication/AwsIamKmsAuthV1Controller.java
@@ -5,7 +5,6 @@
 
 import com.nike.backstopper.apierror.ApiError;
 import com.nike.backstopper.exception.ApiException;
-import com.nike.cerberus.domain.DomainConstants;
 import com.nike.cerberus.domain.EncryptedAuthDataWrapper;
 import com.nike.cerberus.domain.IamRoleCredentials;
 import com.nike.cerberus.event.AuditLoggingFilterDetails;
@@ -38,12 +37,6 @@ public AwsIamKmsAuthV1Controller(
 
   @RequestMapping(method = POST, consumes = APPLICATION_JSON_VALUE)
   public EncryptedAuthDataWrapper authenticate(@RequestBody IamRoleCredentials request) {
-    String iamPrincipalArn =
-        String.format(
-            DomainConstants.AWS_IAM_ROLE_ARN_TEMPLATE,
-            request.getAccountId(),
-            request.getRoleName());
-
     EncryptedAuthDataWrapper authResponse;
     try {
       authResponse = authenticationService.authenticate(request);

diff --git a/cerberus-web/src/main/java/com/nike/cerberus/event/AuditableEventContext.java b/cerberus-web/src/main/java/com/nike/cerberus/event/AuditableEventContext.java
@@ -17,6 +17,7 @@
 package com.nike.cerberus.event;
 
 import com.nike.cerberus.security.CerberusPrincipal;
+import java.io.Serializable;
 import java.time.OffsetDateTime;
 import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
@@ -27,8 +28,9 @@
 /** An event that can be used to describe what a principal is doing with the API */
 @Data
 @Builder
-public class AuditableEventContext {
+public class AuditableEventContext implements Serializable {
 
+  private static final long serialVersionUID = 2906382176272161512L;
   public static final String UNKNOWN = "_unknown";
 
   private Object principal;