Fix build support for previous Stack LTS versions and drop those no longer supported #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamfromSpace
changed the title
IamfromSpace
force-pushed
the
maint/fix-current-supported-lts
branch
from
082607e
to
30eacec
Compare
IamfromSpace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets older stackage snapshots building by including attoparsec-aeson as an extra dependency. Notably any project that wants to use the new version of hal but an older snapshot will have to do the same. Given that most users will likely move both simultaneously, this seems like an acceptable trade-off for greater compatibility in other areas.
While attoparsec-aeson absolutely could relax their bounds to support LTS 11 and 12, they have inexplicably refused to do so. Without this, there aren't many good options on the table, so for the moment, we're going to drop support for 11 and 12 for this version forward.