Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal.cabal: Add CHANGELOG.md to extra-source-files #88

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Apr 13, 2021

This'll make it show up as a change log on future hackage releases.

@IamfromSpace
Copy link
Collaborator

Didn't realize this wasn't included before! The cabal file is currently autogenerated, so we'll need to both add this to the package.yaml and update the cabal file hash. Been doing this a lot, so I added a patch-1 branch to this repo with a commit on top that does this; you can just pull it in to do so!

@endgame
Copy link
Contributor Author

endgame commented Apr 13, 2021

I think cabal check warns about such things, but not sure if it catches this one. Dunno about stack workflows.

@endgame
Copy link
Contributor Author

endgame commented Apr 13, 2021

Running hpack doesn't seem to add any more changes to the cabal file, so I think we're good to go.

@IamfromSpace
Copy link
Collaborator

Dunno about stack workflows.

Yeah, I'm still not sure the best way to handle this either, I've got an open issue #75. Without it's a pain for anyone who wants to pull the package from git using cabal, but it's a gotcha with it. 🤷‍♂️

Looks good to go here though!

@IamfromSpace IamfromSpace merged commit fc5318d into Nike-Inc:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants