Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kiota SDK to Keycloak 25.0.0. #119

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

kanpov
Copy link
Contributor

@kanpov kanpov commented Jun 14, 2024

No description provided.

@NikiforovAll
Copy link
Owner

@kanpov could you please run csharpier for generated code (see dotent-tool manifest file for more details). the goal is to have less diffs

@kanpov
Copy link
Contributor Author

kanpov commented Jun 15, 2024

@kanpov could you please run csharpier for generated code (see dotent-tool manifest file for more details). the goal is to have less diffs

I ran dotnet csharpier . on the Kiota SDK project and it changed nothing, at least as far as git status tells me.
image

@NikiforovAll
Copy link
Owner

Could you please run dotnet tool install Microsoft.OpenApi.Kiota in the root of the project and add the changes? I want to pin the version of kiota essentially :)

@kanpov
Copy link
Contributor Author

kanpov commented Jun 15, 2024

Could you please run dotnet tool install Microsoft.OpenApi.Kiota in the root of the project and add the changes? I want to pin the version of kiota essentially :)

Done

@kanpov
Copy link
Contributor Author

kanpov commented Jun 15, 2024

Also the Windows test run somehow now fails for a typical Windows reason:
image
Not anymore :)

@kanpov
Copy link
Contributor Author

kanpov commented Jun 15, 2024

image
Why this is happening I have no idea to be honest.

@NikiforovAll NikiforovAll merged commit 5ff66a5 into NikiforovAll:main Jun 15, 2024
7 checks passed
@NikiforovAll
Copy link
Owner

I think it is just changes of how code generated by kiota in 1.15.0

@NikiforovAll
Copy link
Owner

Thank you for the contribution, the changes will be deployed as part of 2.5.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants