-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update kiota api to 25.0.2 #129
Conversation
I'm going to investigate the src/Directory.Packages.props conflict. Are the other conflicts of issue? I'd think not since they're generated but I'm not sure if that's due to something being generated incorrectly. |
29de373
to
d0e7738
Compare
I figured it out, I had an outdated main. I'll rebase and push the changes. |
fd98fc6
to
34fe2d4
Compare
Can we somehow reduce the number of changes? I remember pinning the Kiota tool version that should be used for generations to avoid these massive changes. Could you please provide a version of the kiota tool that was used for the process of generation? |
It was 1.16.0 to build this and the prior version according to the lock file was 1.15.0. I'll downgrade, rerun this, and push the changes. |
Follow up on this, my goal here was to bring in the organization APIs since those are new for 25 and I just assumed that 25.0.0 didn't have them for whatever reason but it turns out they're just plain missing from the openapi definition file at this moment. keycloak/keycloak#30832 Once that's addressed, I'll update this PR. Until then I'll put it in a draft state but if that's undesirable for you, feel free to close it and I can always reopen it. |
It would be great if after creating a Role or Group, the ID of the created entity could be returned. @Persistent13 |
Closing in favor of #154 |
This updates the Kiota package to the 25.0.2 release of Keycloak.
I think this is all good but please let me know if you need anything else from me!