Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed relative address construction #156

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

juan-dev-santos
Copy link
Contributor

(This is my first pull request so any feedback on how to improve is welcomed)

I have changed the initial '/' in ApiUrls that was avoiding correct relative uri construction and also added a test to verify it is working

@NikiforovAll
Copy link
Owner

Hi @juan-dev-santos, could you please rebase onto the main?

@juan-dev-santos
Copy link
Contributor Author

Hi @juan-dev-santos, could you please rebase onto the main?

Sorry but how should I do it?

This is the first time contributing

@juan-dev-santos
Copy link
Contributor Author

I have merged last changes into my fork and sent a PR again
Is this what you were asking me?

@NikiforovAll NikiforovAll merged commit 0e1ae3c into NikiforovAll:main Nov 23, 2024
7 checks passed
@NikiforovAll
Copy link
Owner

@juan-dev-santos thank you for the contribution! I will include it in the next release - 2.5.4

@juan-dev-santos
Copy link
Contributor Author

@juan-dev-santos thank you for the contribution! I will include it in the next release - 2.5.4

Thanks! Glad I could help

@taufikdev88
Copy link

Hello, can you do retest for this PR, because this PR caused the Admin-Http-Client on Keycloak.AuthServices.Sdk does not build correct ApiUrls path

generated url is: /realms/{realm}/admin/realms/{realm}/groups

expected: /admin/realms/{realm}/groups

image

@taufikdev88
Copy link

maybe just replace base url using keycloak-auth-url only without realm will solved the issue ?
image

@NikiforovAll
Copy link
Owner

NikiforovAll commented Nov 30, 2024

Oh yes, good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants