wip

libs/zk/include/nil/crypto3/zk/commitments/polynomial/kzg_v2.hpp

@@ -190,6 +190,7 @@ namespace nil {
                     // Differs from static, because we pack the result into byte blob.
                     commitment_type commit(std::size_t index) {
                         this->_ind_commitments[index] = {};
+                        this->_ind_commitments[index].resize(this->_polys[index].size());
                         this->state_commited(index);
 
                         std::vector<std::uint8_t> result = {};

libs/zk/include/nil/crypto3/zk/snark/systems/plonk/placeholder/gates_argument.hpp

@@ -88,7 +88,9 @@ namespace nil {
                         });
                         std::shared_ptr<math::evaluation_domain<FieldType>> extended_domain =
                             math::make_evaluation_domain<FieldType>(extended_domain_size);
+
                         visitor.visit(expr);
+
                         for (const auto& [var, count]: variable_counts) {
                             // We may have variable values in required sizes in some cases.
                             if (variable_values_out.find(var) != variable_values_out.end())

libs/zk/include/nil/crypto3/zk/snark/systems/plonk/placeholder/lookup_argument.hpp

@@ -546,7 +546,7 @@ namespace nil {
                     }
 
                     // Each lookup table should fill full rectangle inside assignment table
-                    // Lookup tables may contain repeated values, but they shoul be placed into one
+                    // Lookup tables may contain repeated values, but they should be placed into one
                     // option one under another.
                     // Because of theta randomness compressed lookup tables' vectors for different table may contain
                     // similar values only with negligible probability.