Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating all the repos after removing duplicate files. #90

Closed
wants to merge 5 commits into from
Closed

Updating all the repos after removing duplicate files. #90

wants to merge 5 commits into from

Conversation

martun
Copy link
Contributor

@martun martun commented Oct 24, 2023

No description provided.

@martun martun self-assigned this Oct 24, 2023
@martun martun linked an issue Oct 24, 2023 that may be closed by this pull request
Remove duplicate files like pack.hpp, type_traits.hpp, unbounded_shift.hpp, endian_shift.hpp etc. #89
Closed
@martun martun marked this pull request as draft October 24, 2023 14:22
@nemothenoone
Copy link
Member

This one cannot be merged in. Submodules others than zk which can work without zk, also use them.

@martun
Copy link
Contributor Author

martun commented Oct 25, 2023 •
edited
Loading

This one cannot be merged in. Submodules others than zk which can work without zk, also use them.

@nemothenoone Ok, but we need to decide where to put these files. Now they are in 7 copies each, each copy slightly different, and all with the same #ifndef-s. You are never sure which one gets used from zk...

I left 1 copy of each file in the hash repo, can't everyone else depend on the crypto3-hash? They will not need to change even the #include statements, just add dependency on crypto3-hash.

@martun martun requested a review from nkaskov October 25, 2023 10:51
@nemothenoone
Copy link
Member

@martun We can emplace them in some most low-level library? Something like https://github.com/NilFoundation/crypto3-block?

@martun
Copy link
Contributor Author

martun commented Oct 25, 2023

@martun We can emplace them in some most low-level library? Something like https://github.com/NilFoundation/crypto3-block?

Yep, we can. @nkaskov do you agree?

@martun martun marked this pull request as ready for review November 3, 2023 13:47
@martun martun force-pushed the 89-remove-duplicate-files-like-packhpp-type_traitshpp-unbounded_shifthpp-endian_shifthpp-etc branch from 2aa39c0 to db8e568 Compare November 3, 2023 13:50
@martun martun force-pushed the 89-remove-duplicate-files-like-packhpp-type_traitshpp-unbounded_shifthpp-endian_shifthpp-etc branch from 2b6a8cf to dfcddd7 Compare November 3, 2023 14:08
@martun martun marked this pull request as draft November 6, 2023 08:05
@martun martun closed this Mar 5, 2024
AndreyMlashkin pushed a commit that referenced this pull request Aug 15, 2024
@tshchelovek
bit_decompposition component+test interface update #90
cfcd08b
AndreyMlashkin pushed a commit that referenced this pull request Aug 15, 2024
@ETatuzova
Update assignment table profiling #90
5fbb2bd
AndreyMlashkin pushed a commit that referenced this pull request Aug 15, 2024
@tshchelovek
scalar_non_native_range component+test interface update #90
c78a6b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkaskov nkaskov Awaiting requested review from nkaskov

Assignees

@martun martun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate files like pack.hpp, type_traits.hpp, unbounded_shift.hpp, endian_shift.hpp etc.
2 participants
@martun @nemothenoone