assigner: add trace match check #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokoshn
reviewed
Dec 23, 2024
proof-producer/libs/assigner/include/nil/proof-generator/assigner/bytecode.hpp
Outdated
Show resolved
Hide resolved
proof-producer/libs/assigner/include/nil/proof-generator/assigner/copy.hpp
Outdated
Show resolved
Hide resolved
proof-producer/libs/assigner/include/nil/proof-generator/assigner/trace_parser.hpp
Outdated
Show resolved
Hide resolved
oclaw
force-pushed
the
feature/check-trace-matches
branch
2 times, most recently
from
b61ab37 to
f86f4aa
Compare
makxenov
reviewed
Dec 30, 2024
proof-producer/libs/assigner/include/nil/proof-generator/assigner/options.hpp
Show resolved
Hide resolved
akokoshn
approved these changes
Dec 30, 2024
makxenov
reviewed
Jan 2, 2025
proof-producer/tests/bin/proof-producer/test_zkevm_bbf_circuits.cpp
Outdated
Show resolved
Hide resolved
oclaw
force-pushed
the
feature/check-trace-matches
branch
from
f86f4aa to
a4b40a2
Compare
oclaw
force-pushed
the
feature/check-trace-matches
branch
from
a4b40a2 to
b5a35a4
Compare
makxenov
approved these changes
Jan 7, 2025
oclaw
force-pushed
the
feature/check-trace-matches
branch
from
b5a35a4 to
2930884
Compare
x-mass
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to trace protobuf randomly generated value from trace_idx in order to check if all trace files passed to assigner are compatible to each other. Added option to skip this check if needed (not used now) + unit test with inconsistent data.
Old traces are not required to be re-generated, changes are not breaking
Also cleaned up assigner a bit