Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use cm deploy #43

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Dont use cm deploy #43

merged 8 commits into from
Sep 25, 2024

Conversation

AndreyMlashkin
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Clang Test Results

  153 files  ±0    153 suites  ±0   6m 55s ⏱️ -3s
3 198 tests ±0  3 192 ✅ ±0  6 💤 ±0  0 ❌ ±0 
3 265 runs  ±0  3 259 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 0a9e1d7. ± Comparison against base commit dabeb06.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Gcc Test Results

  153 files  ±0    153 suites  ±0   8m 4s ⏱️ -3s
3 198 tests ±0  3 192 ✅ ±0  6 💤 ±0  0 ❌ ±0 
3 265 runs  ±0  3 259 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 0a9e1d7. ± Comparison against base commit dabeb06.

♻️ This comment has been updated with latest results.

akokoshn
akokoshn reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally ok for me. Let's wait approve from @vo-nil

x-mass
x-mass approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@x-mass x-mass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to use this upadted version from other packages? Just to be sure nothing is broken

@AndreyMlashkin
Copy link
Collaborator Author

Have you tried to use this upadted version from other packages? Just to be sure nothing is broken

Yes, everything worked for me :)

@AndreyMlashkin AndreyMlashkin merged commit ff2a92c into master Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akokoshn akokoshn akokoshn left review comments

@x-mass x-mass x-mass approved these changes

@vo-nil vo-nil Awaiting requested review from vo-nil

@ETatuzova ETatuzova Awaiting requested review from ETatuzova

Assignees

@AndreyMlashkin AndreyMlashkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreyMlashkin @akokoshn @x-mass