Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprecision refactoring #98

Draft
wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

Multiprecision refactoring #98

wants to merge 51 commits into from
+5,843 −1

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Oct 18, 2024

No description provided.

@ioxid ioxid requested a review from martun October 18, 2024 16:07
@ioxid ioxid self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Clang Test Results

  161 files  +  8    161 suites  +8   12m 19s ⏱️ -1s
3 580 tests + 39  3 574 ✅ + 39  6 💤 ±0  0 ❌ ±0 
3 765 runs  +164  3 759 ✅ +164  6 💤 ±0  0 ❌ ±0 

Results for commit 39f3101. ± Comparison against base commit 925420c.

This pull request removes 6 and adds 45 tests. Note that renamed tests count towards both. 
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

addition ‑ does_not_wrap
addition ‑ does_not_wrap_rev
addition ‑ multilimb
addition ‑ multilimb_rev
addition ‑ simple
convert ‑ from_int64_t
convert ‑ from_uint64_t
convert ‑ to_uint64_t
cpp_int_conversion ‑ from_cpp_int
cpp_int_conversion ‑ to_cpp_int
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Gcc Test Results

  161 files  + 8    161 suites  +8   14m 14s ⏱️ ±0s
3 586 tests +45  3 580 ✅ +45  6 💤 ±0  0 ❌ ±0 
3 672 runs  +71  3 666 ✅ +71  6 💤 ±0  0 ❌ ±0 

Results for commit 39f3101. ± Comparison against base commit 925420c.

♻️ This comment has been updated with latest results.

@ioxid ioxid force-pushed the multiprecision-refactoring branch 3 times, most recently from 656991a to f0ffd23 Compare November 4, 2024 13:32
@ioxid ioxid force-pushed the multiprecision-refactoring branch 7 times, most recently from bc46774 to 2f18e78 Compare November 13, 2024 10:46
@ioxid ioxid force-pushed the multiprecision-refactoring branch 2 times, most recently from 89d442a to 708e3db Compare November 13, 2024 20:14
@ioxid
Cleanup import-export a little
7fafd9b
@ioxid
Rename getters in modular integer
4d5fa05
@ioxid
Introduce NIL_CO3_MP_USE_LIMB_SHIFT
8dcf93c
@ioxid
Remove operator= from string in modular integer
3f5008a
@ioxid
Cleanup TODOs and refactor modular template parameters
8c0c1db
@ioxid
Cleanup inverse
c0b77c9
@ioxid
Fix to string tests
afb02f7
@ioxid
Fix modular constructors and implement hash for signed big integer
0efc546
@ioxid
Implement faster increment and decrement for modular
1aaa5db
@ioxid
Cleanup and fix modular integer constructors
d3d0a9c
@ioxid
Cleanup TODOs
76d2412
@ioxid
Cleanup big_integer
21b4ce8
@ioxid
Rename big_integer to big_uint
dbebb3c
@ioxid
Reinstate comment in ressol about error condition
d922014
@ioxid
Refactor modular ops template parameters
6a02070
@ioxid
Remove unused function
ee53f55
@ioxid
Add inline to static constexpr variables
33ed611
@ioxid
Refactor macro names in modular ops
c71543c
@ioxid
Refactor modular ops: rename methods
0e5c171
@ioxid
Refactor tests
4a7967a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun Awaiting requested review from martun

At least 1 approving review is required to merge this pull request.

Assignees

@ioxid ioxid

Labels
multiprecision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioxid