Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export table styled elements #269

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Export table styled elements #269

merged 6 commits into from
Mar 27, 2024

Conversation

ukorvl
Copy link
Member

@ukorvl ukorvl commented Mar 25, 2024

This diff adds export table styled elements. This elements keep table semantically correct (they use <table>, <tr>, <td> tags under the hood), but make it more flexible. Styled table elements give the direct access to table elements, meanwhile TableBuilder provides access only to its content.
Also, it moves createSRRTest into test-utils dir which is more correct.

@ukorvl ukorvl self-assigned this Mar 25, 2024
Copy link

github-actions bot commented Mar 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/ui-kit.js 82.89 KB (+0.29% 🔺) 1.7 s (+0.29% 🔺) 179 ms (+174.22% 🔺) 1.9 s

@ukorvl ukorvl requested a review from KlonD90 March 25, 2024 13:26
Copy link
Contributor

@KlonD90 KlonD90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scan it. looks ok

@ukorvl ukorvl merged commit 1311040 into master Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants