Code cleanup v1 #181
Merged
Code cleanup v1 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleasims
force-pushed
the
refactoring
branch
from
a8dad9e to
d52e6c7
Compare
|
Tests will be run in sync with other PRs containing |
aleasims
force-pushed
the
refactoring
branch
3 times, most recently
from
0800c9d to
cf7f7fc
Compare
akokoshn
approved these changes
Feb 18, 2024
Old name is an obsolete one. This memory is no longer only stack memory.
And also rename related entities. Name "parser" is not representative now. We always use name "assigner" now. So it seems logical to rename this.
Since parser was renamed to assigner, we should also rename the source file name.
This is done to avoid ugly constructions when checking generation mode.
aleasims
force-pushed
the
refactoring
branch
from
cf7f7fc to
0484f84
Compare
makxenov
approved these changes
Feb 20, 2024
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Feb 21, 2024
This update brings new refactored version of assigner. See changes in NilFoundation/zkllvm-assigner#181
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Feb 21, 2024
This update brings new refactored version of assigner. See changes in NilFoundation/zkllvm-assigner#181
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Feb 21, 2024
Updates: * Refactored version of assigner (see NilFoundation/zkllvm-assigner#181) * `exit_check_eq_pallas` intrinsic handling (see NilFoundation/zkllvm-assigner#191)
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Feb 21, 2024
Updates: * Refactored version of assigner (see NilFoundation/zkllvm-assigner#181) * `exit_check_eq_pallas` intrinsic handling (see NilFoundation/zkllvm-assigner#191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closing this issue:
Here are some code refactoring and cleanups.
It may be more handy to review changes with commits one by one. Each commit has some explanations of changes made.