Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PRINT_LLVM_OBJECT macro #210

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Implement PRINT_LLVM_OBJECT macro #210

merged 1 commit into from
Mar 22, 2024

Conversation

aleasims
Copy link
Contributor

This macro helps dumping LLVM entities to strings.

@aleasims aleasims requested review from akokoshn and makxenov March 12, 2024 18:02
@aleasims aleasims self-assigned this Mar 12, 2024
@aleasims aleasims linked an issue Mar 12, 2024 that may be closed by this pull request
Add macro for printing LLVM entities to string #209
Closed
akokoshn
akokoshn requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an CI run

include/nil/blueprint/macros.hpp Outdated Show resolved Hide resolved
include/nil/blueprint/macros.hpp Outdated Show resolved Hide resolved
@aleasims aleasims force-pushed the 209-llvm-print-macros branch from 46cbb9d to 3e49602 Compare March 13, 2024 14:52
@aleasims aleasims changed the title Implement PRINT_LLVM_OBJECT macro [SyncWith:zkllvm#572] Implement PRINT_LLVM_OBJECT macro Mar 13, 2024
@aleasims aleasims force-pushed the 209-llvm-print-macros branch from 3e49602 to db5793a Compare March 13, 2024 15:00
@nil-foundation-cicd-bot nil-foundation-cicd-bot bot mentioned this pull request Mar 13, 2024
Closed
@nil-foundation-cicd-bot
Copy link

Tests will be run in sync with other PRs containing [SyncWith NilFoundation/zkLLVM#572] in title. You can find related PRs as linked with mentioned issue.

@aleasims aleasims changed the title [SyncWith:zkllvm#572] Implement PRINT_LLVM_OBJECT macro Implement PRINT_LLVM_OBJECT macro Mar 13, 2024
@aleasims
Copy link
Contributor Author

CI run here:
https://github.com/NilFoundation/zkLLVM/pull/573/checks

@aleasims
Copy link
Contributor Author

CI passed

@aleasims aleasims force-pushed the 209-llvm-print-macros branch from db5793a to 06de471 Compare March 18, 2024 09:21
@aleasims aleasims requested review from akokoshn and makxenov March 18, 2024 09:22
@aleasims
Implement PRINT_LLVM_OBJECT macro
087c420 
This macro helps dumping LLVM entities to strings.
See #209
@aleasims aleasims force-pushed the 209-llvm-print-macros branch from 06de471 to 087c420 Compare March 21, 2024 14:39
@aleasims
Copy link
Contributor Author

Ready for merge

akokoshn
akokoshn requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@akokoshn akokoshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's align all include guards in this PR

@aleasims
Copy link
Contributor Author

@akokoshn I've already done it, include guards in added file are in Google style.

@aleasims aleasims merged commit 677d874 into master Mar 22, 2024
1 check passed
@aleasims aleasims deleted the 209-llvm-print-macros branch March 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akokoshn akokoshn akokoshn approved these changes

@makxenov makxenov Awaiting requested review from makxenov

Assignees

@aleasims aleasims

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add macro for printing LLVM entities to string
3 participants
@aleasims @akokoshn @makxenov