Feat: Add array comparison methods. #60
Conversation
jcabrero
force-pushed
the
feat/add_array_comparison
branch
from
d7b8738
to
8db9bc4
Compare
| Returns: | ||
| NadaArray: A boolean array representing the element-wise inequality comparison result. | ||
| """ | ||
| return self.__comparison_operator(value, lambda x, y: ~(x == y)) |
There was a problem hiding this comment.
I am impressed this is passing the tests. Afaik there is no boolean operations like negation in Nada.
There was a problem hiding this comment.
Just checked in the code base and we already support the not operation. We should update the docs then.
There was a problem hiding this comment.
I know, I was also not fully aware of how to implement this, and had to look through the code base to find it.
jcabrero
force-pushed
the
feat/add_array_comparison
branch
from
8db9bc4
to
7ad1e83
Compare
| """ | ||
| Perform element-wise comparison with broadcasting. | ||
|
|
||
| NOTE: Specially for __eq__ and __ne__ operators, the result expected is bool. |
There was a problem hiding this comment.
Is this the expected result? In numpy, __ eq __ and __ ne __ are broadcasted
I believe this implementation matches that behaviour, no?
There was a problem hiding this comment.
Yes, in NumPy, those two operations are indeed broadcasted. However, there's an unusual behavior when you try to do array_a == array_b. NumPy evaluates the boolean value of each element, as these operations are expected to result in either True or False. For instance, it will determine whether a SecretInteger is True or False—which always turns out to be True.
nada_numpy/array.py
Outdated
| @@ -390,6 +390,106 @@ def __imatmul__(self, other: Any) -> "NadaArray": | |||
| """ | |||
| return self.matmul(other) | |||
|
|
|||
| def __comparison_operator(self, value: Any, operator: Callable) -> "NadaArray": | |||
There was a problem hiding this comment.
Can we use .apply here?
jcabrero
force-pushed
the
feat/add_array_comparison
branch
from
1620cf1
to
58be49f
Compare
This PR introduces support for Array Comparison Methods i.e.,
==,!=,>,>=,<,<=. This enables certain use cases where users where trying to use the comparison operators with Nillion.Apart from this it also: