Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contributing guidelines #63

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

manel1874
Copy link
Member

Added contributing guidelines as a separate file.

CONTRIBUTING Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this file be named CONTRIBUTING.md?

Copy link
Member

@jcabrero jcabrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This looks very nice.

Copy link
Contributor

@mathias-nillion mathias-nillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one dead link in doc (small typo)

README.md Outdated

Please join the Nillion community on [Discord](https://discord.com/invite/nillionnetwork).

See the [CONTRIBUTING](./CONTRIBUTING) file for how to contribute to `nada-numpy`.
Copy link
Contributor

@mathias-nillion mathias-nillion Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manel1874 this link is now dead --> CONTRIBUTING.md

@manel1874 manel1874 merged commit b94657e into main Aug 28, 2024
4 checks passed
@manel1874 manel1874 deleted the update-readme-contributions branch September 12, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants