feat: improve tests for shuffle feature #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jfdreis <[email protected]>
jimouris
approved these changes
Sep 10, 2024
Comment on lines
+64
to
+69
| check = Integer(0) | ||
| for ai in a: | ||
| nr_ai_in_shufled_a = count(shuffled_a, ai) | ||
| nr_ai_in_a = count(a, ai) | ||
| check += bool_to_int(nr_ai_in_shufled_a == nr_ai_in_a) | ||
| elements_are_preserved = check == Integer(0) |
There was a problem hiding this comment.
This is n^2, if we have nlogn sorting it'd make sense to sort both and check them one by one. Otherwise, this is also good -- it's meant to be just an example.
There was a problem hiding this comment.
That is true. Although you can have repetitions. So, if you have repeated numbers you have to count them anyway and check that the number of elements match.
Just noticed that with the new way of testing we can do all this in the clear. I will merge this anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving shuffling tests to: