Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing testing infrastructure fail #74

Merged
merged 8 commits into from
Sep 30, 2024
Merged

fix: fixing testing infrastructure fail #74

merged 8 commits into from
Sep 30, 2024

Conversation

jcabrero
Copy link
Member

@jcabrero jcabrero commented Sep 25, 2024 •
edited
Loading

This morning @navasvarela pointed out that to_public was available in version 0.6.3 of Nada DSL. Nada Numpy did not take that into account.

This PR includes the following:

  • Fixes the tests to ensure all of them are executed and outputs are considered.
  • It adds corrections to make it compatible and work with the latest version of Nada DSL.
  • It fixes the matrix inverse code. The test verifies that for any dimension A @ A_inv = Identity.

@jcabrero jcabrero self-assigned this Sep 25, 2024
@jcabrero jcabrero requested a review from manel1874 September 25, 2024 17:35
manel1874
manel1874 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@manel1874 manel1874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcabrero jcabrero merged commit f3c98b1 into main Sep 30, 2024
4 checks passed
@jcabrero jcabrero deleted the fix/change_reveal_to_public branch November 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manel1874 manel1874 manel1874 approved these changes

@navasvarela navasvarela navasvarela approved these changes

Assignees

@jcabrero jcabrero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcabrero @navasvarela @manel1874