Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding general shuffle example for any vector size #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manel1874
Copy link
Member

@manel1874 manel1874 commented Oct 14, 2024

This is just a preliminary example for shuffling a vector without any constraint in size. We want to greatly improve on this but we can have it as an example for reference before we include it under nada-numpy.

Note: The example does not support arrays with Rational or SecretRational types.

Optimizations for future reference:

  1. Add support for random boolean in nada dsl directly,
  2. Avoid truncation,
  3. Add support for one_hot_vector as a preprocessing element from nada dsl.

Copy link
Member

@jcabrero jcabrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍 . Just one small comment, in tests/test_all.py, add this example to the list EXAMPLES. In that way, we test all examples with the CI and ensure they all work with the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants