Bugfix/log merging #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should assume that the calculation from PHPUnit is correct so we have to recalculate the base node only. Add Subnodes of testcase node also beacuse it contains important error messages
check log directory existence fix styleci issues fix style ci issues remove .Log from gitignore fix style ci issues
Forestsoft-de
force-pushed
the
bugfix/log-merging
branch
from
fea6f14
to
1cd43f8
Compare
Hernan-Aranda-Prado
added a commit
to digidip/phpunit-merger
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive detected that merging of logs doesnt work. You check in your testcase if an file exists but the file contains only
<testsuites />Check Line 85 to see how its fixed.
Ive added an testcase for that behavior and use a dataset of my 2 phpunit runs.
We should get rid of calculation for each node also, because im sure that phpunit make a great job here and we should calulate the top node only.
Line 98
Adding 0 as a default value breaks sonar with importing any result because its not able to validate the file path.
In Line 145 we add the Test result to the merged file also.
Br
Sebastian