Go tweaks #251
Merged
Go tweaks #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move main.go to root like go expects
Esgrove
commented
Nov 6, 2023
Comment on lines
+29
to
+30
| nVault := initVault() | ||
| all(nVault) |
Esgrove
commented
Nov 6, 2023
Comment on lines
+22
to
+25
| if *versionFlag { | ||
| fmt.Println(VersionInfo()) | ||
| os.Exit(0) | ||
| } |
There was a problem hiding this comment.
➜ go git:(go-tweaks) ✗
./nitor-vault --version
1.0.0 2023-11-06T10:52:07Z go-tweaks 56179584315cbe480e377a54bdac7d2d7f4fe863 go1.21.3 arm64
kahlstrm
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go buildandgo rundirectly (andgo install). @kahlstrm did you have a particular reason for the previous code organization?