packaging: move tests to passthru

[Mic92]

Motivation

This is unnecessary build tests in some builds, where we don't actually need it.
It is useful to build nix without having to run tests.
Before when running vm tests we were also building unittests.

Context

---

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

[roberth]

The VM tests already run with

        nix.package = nixpkgsFor.${system}.native.nixComponents.nix-cli;

and nix-cli does not include tests.
(It's an input to everything.nix, not its return value)

Another possibility would be to override the doCheck and doInstallCheck attrs to false where desired.

I don't think we should do this before we have something like

• Assertion quasi-derivations #11955

[Mic92]

The VM tests already run with

        nix.package = nixpkgsFor.${system}.native.nixComponents.nix-cli;

They still seem to build all those tests for some reasons. Why do we need to define tests as check inputs? I don't see the advantage. If someone wants to do nix run github:NixOS/nix they shouldn't have to build tests. This is an anti-pattern that we inherited from nixpkgs, but now we could avoid.

[Mic92]

@mergify queue

[mergify]

queue

🛑 The pull request has been synchronized by a user

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-12-16-nix-team-meeting-minutes-203/57483/1

[Mic92]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased