fix: ignore symlinks in fsync-store-paths #12103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at bff9296 |
cole-h
reviewed
Dec 25, 2024
| @@ -331,15 +331,16 @@ void syncParent(const Path & path) | |||
|
|
|||
| void recursiveSync(const Path & path) | |||
| { | |||
| /* If it's a file, just fsync and return. */ | |||
| /* If it's a file or symlink, just fsync and return. */ | |||
There was a problem hiding this comment.
nit: this comment is wrong, if I'm reading the code correctly:
If it's a file, fsync and return; if it's a symlink, just return without fsyncing.
roberth
added
backport 2.24-maintenance
This was referenced Jan 10, 2025
mergify bot
added a commit
that referenced
this pull request
Jan 10, 2025
…2103 fix: ignore symlinks in fsync-store-paths (backport #12103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When fsync-store-paths is enabled, during nix copy symlink store entries are treated as directory, which is not correct.
Context
Fixes #12099
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.