-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
framework: refactor kmod for improved AMD support #1029
base: master
Are you sure you want to change the base?
Conversation
1e5489e
to
dac8121
Compare
Bump :p |
dac8121
to
80ff85f
Compare
The kernel now fails to build with 6.11. |
There was a patch yesterday that landed on stable and unstable that makes it work on 6.11. Should be fine now, it's working on my machine. |
Awesome I will give it another go today. Thanks!
…On September 21, 2024 8:34:16 AM PDT, quatquatt ***@***.***> wrote:
> The kernel now fails to build with 6.11.
There was a patch yesterday that landed on stable and unstable that makes it work on 6.11. Should be fine now, it's working on my machine.
--
Reply to this email directly or view it on GitHub:
#1029 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
80ff85f
to
f0dedf3
Compare
Changes several aspects of framework-laptop-kmod support: - default value has been changed to true when NixOS >= 24.05 and linux kernel >=6.10, and false otherwise - adds required patch for framework AMD enablement when kernel <6.10 - add README section describing usage
f0dedf3
to
4c0d42b
Compare
What is the reason this is marked as draft? |
it looks like you marked it as a draft during the review comments. if you think those issues still need to be addressed in some way, i'm happy to make further changes. otherwise, it would be fine to remove the draft status -- it doesn't look like i can do it myself my personal daily laptop is running nixos-hardware from my own branch here and at this point it's been working with no issues for >6 months. my use case was solely to get the battery charge limit showing up in KDE, so i could extend my battery lifespan |
Description of changes
Fixes #1028
Changes several aspects of framework-laptop-kmod support:
Also: this may be an upstream nixpkgs issue, but the lack of a good lore.kernel.org fetcher is kind of surprising. I tried using this sample code with
fetchpatch
initially, but got weird errors with it. I implemented afetchb4
fetcher for my own personal usage, which usesb4
to download and format patches from https://lore.kernel.org and the skeleton of that is present in this PR usingrunCommand
for simplicityThings done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake inputEdit: I've been running this on my own framework 16 for a bit now and everything seems to be working fine