Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pantheon updates 2021-10-25, 2021-10-26 #142810

Merged
merged 14 commits into from
Oct 28, 2021
Merged

Pantheon updates 2021-10-25, 2021-10-26 #142810

merged 14 commits into from
Oct 28, 2021

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Oct 25, 2021 •
edited
Loading

Motivation for this change

Part of Pantheon 6.0.3 updates (previous one at #142633).

For upcoming package updates, see https://github.com/orgs/elementary/projects/90#column-16173879

Also adds xdg-desktop-portal-pantheon.

This is ready for review, but I am drafting this as I haven't tested this myself yet. I am testing the change now, but there are some changes I still feel unsure, please help reviewing the changes, thank you!

2021-10-26:

#142810 (comment)

2021-10-25:

touchegg

https://github.com/JoseExposito/touchegg/releases/tag/2.0.12
JoseExposito/touchegg@2.0.11...2.0.12

  • Improve pinch gesture detection on touchscreens
  • Honor the XDG basedir specification

pantheon.touchegg still works on Pantheon.
The current installation path for configuration files ($out/share/touchegg/touchegg.conf) should still be respected.

granite

https://github.com/elementary/granite/releases/tag/6.1.2
elementary/granite@6.1.1...6.1.2

  • Use values from the Settings Portal when possible
  • Disable horizontal scrolling by default in SettingsPage
  • Updated translations

Not sure if I need to take any actions based on this change:

settings-daemon

https://github.com/elementary/settings-daemon/releases/tag/1.1.0
elementary/settings-daemon@1.0.0...1.1.0

New features:

  • Provide the Settings portal

Improvements:

  • Remove unused dark style gsettings schema
  • Updated translations

io.elementary.settings-daemon.xdg-desktop-portal.service starts.
notejot (random libadwaita app) now respects dark mode from Pantheon switchboard settings.

portals

(First release) https://github.com/elementary/portals/tree/1.0.0
https://github.com/elementary/portals/releases/tag/1.0.0

  • Add OpenURI Portal

xdg-desktop-portal-pantheon.service starts.
FYI, there is a WIP https://github.com/elementary/portals/tree/demo/demo and I packaged this, not sure if it is useful though.

wingpanel-indicator-network

https://github.com/elementary/wingpanel-indicator-network/releases/tag/2.3.1
elementary/wingpanel-indicator-network@2.3.0...2.3.1

Fixes:

  • Don't launch Captive Network Assistent with full connectivity

Minor updates:

  • Updated translations
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bobby285271 bobby285271 requested a review from davidak October 25, 2021 04:35
@bobby285271 bobby285271 changed the title touchegg: 2.0.11 -> 2.0.12 Pantheon updates 2021-10-25 Oct 26, 2021
@bobby285271 bobby285271 marked this pull request as draft October 26, 2021 00:06
@bobby285271 bobby285271 mentioned this pull request Oct 26, 2021
Closed
12 tasks
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 26, 2021
@bobby285271 bobby285271 added the 8.has: package (new) This PR adds a new package label Oct 26, 2021
@bobby285271 bobby285271 marked this pull request as ready for review October 26, 2021 04:22
@bobby285271

This comment has been minimized.

Sign in to view
@bobby285271 bobby285271 requested a review from jtojnar October 26, 2021 04:53
jtojnar
jtojnar reviewed Oct 26, 2021
View reviewed changes
pkgs/desktops/pantheon/desktop/wingpanel-indicators/network/default.nix
patches = [
(substituteAll {
src = ./fix-paths.patch;
elementary_capnet_assist = elementary-capnet-assist;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elementary-capnet-assist can be dropped from args.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure the package is installed so that the indicator can find its desktop file.

@jtojnar
Copy link
Member

jtojnar commented Oct 26, 2021

Any particular concerns? Changes look about right to me.

@bobby285271

This comment has been minimized.

Sign in to view
@bobby285271 bobby285271 force-pushed the pantheon branch 2 times, most recently from 02c346c to a57a7c0 Compare October 26, 2021 10:25
@bobby285271

This comment has been minimized.

Sign in to view
@davidak
Copy link
Member

davidak commented Oct 26, 2021

I will test soon. Thanks for the updates!

@bobby285271
Copy link
Member Author

bobby285271 commented Oct 26, 2021 •
edited
Loading

After more testing, I came up a conclusion that wingpanel did not disappear from the pantheon greeter, it just loads much slower now, after waking up the machine, I need to wait at most 20-30 seconds for wingpanel to appear on my greeter. So if reverting elementary/granite#529 resolves the issue, I guess it just means reading something from the portal does take some time (sorry I am not familiar with portals and not sure if this is really related and these are just my guessings)...

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 26, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-linux: 1-10 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Oct 26, 2021
@bobby285271 bobby285271 changed the title Pantheon updates 2021-10-25 Pantheon updates 2021-10-25, 2021-10-26 Oct 27, 2021
@bobby285271 bobby285271 marked this pull request as draft October 27, 2021 00:08
@bobby285271
Copy link
Member Author

bobby285271 commented Oct 27, 2021 •
edited
Loading

Not sure what is happening with ofborg?

But since this is not merged, I am going to push the 2021-10-26 updates here. As granite has already caused a rebuild for almost every Pantheon packages, I hope it will be fine to do so...

epiphany

We have new tab-view: Update close button position on startup patch to add. The patch is also in upstream, see https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1025

calculator

https://github.com/elementary/calculator/releases/tag/1.7.1
elementary/calculator@1.7.0...1.7.1

Minor updates:

  • Showing advanced controls only affects the focused window
  • Focus the main text entry on startup
  • Show the correct window title in Multitasking View
  • Updated translations
  • Added 'New Window' Desktop Action

appcenter

https://github.com/elementary/appcenter/releases/tag/3.8.1
elementary/appcenter@3.8.0...3.8.1

Fixes:

  • Don't store $0 app installs as paid
  • Fix missing illicit substances icon
  • Don't show plugins on the homepage
  • Only show "Multiplayer" badge for games

Improvements:

  • Show installation progress in a more compact way
  • Updated translations

Both downstream patches are still needed.

calendar

https://github.com/elementary/calendar/releases/tag/6.0.3
elementary/calendar@6.0.2...6.0.3

Fixes:

  • Ensure Calendar runs in the background on startup
  • Fix memory leak when getting timezone information
  • Reliably read Windows-style timezones

Minor Updates:

  • Updated translations

For the first fix, they updated the exec line in desktop files.

wingpanel-indicator-notifications

https://github.com/elementary/wingpanel-indicator-notifications/releases/tag/6.0.2
elementary/wingpanel-indicator-notifications@6.0.1...6.0.2

Minor updates:

  • Fix DBus listening on Fedora
  • Updated translations

oooooh I found this

photos

https://github.com/elementary/photos/releases/tag/2.7.3
elementary/photos@2.7.2...2.7.3

Fixes:

  • Focus photos on startup when previewing to fix navigating with left and right arrow keys
  • Fix a possible crash with invalid date and time info

Minor updates:

  • Move Toggle Sidebar and Toggle Photo Info actions to the main menubutton
  • Translation updates

applications-menu

https://github.com/elementary/applications-menu/releases/tag/2.9.1
elementary/applications-menu@2.9.0...2.9.1

Improvements:

  • Show secondary click menu for search results
  • Updated translations

camera

https://github.com/elementary/camera/releases/tag/6.0.1
elementary/camera@6.0.0...6.0.1

Improvements:

  • Take full-resolution pictures

Fixes:

  • Fix restoring window size

Minor updates:

  • Updated translations

Still works for me, but unfortunately for davidak elementary/camera#182 probably does not get a fix.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 27, 2021
@ofborg ofborg bot requested a review from dtzWill October 27, 2021 01:21
@bobby285271
Copy link
Member Author

bobby285271 commented Oct 27, 2021 •
edited
Loading

Result of nixpkgs-review pr 142810 run on x86_64-linux 1

94 packages built:
  • agenda
  • akira-unstable
  • appeditor
  • bookworm
  • cipher
  • cozy
  • elementary-planner
  • ephemeral
  • epiphany
  • fondo
  • formatter
  • gnonograms
  • hashit
  • ideogram
  • minder
  • monitor
  • nasc
  • notes-up
  • pantheon-tweaks
  • pantheon.appcenter
  • pantheon.elementary-calculator
  • pantheon.elementary-calendar
  • pantheon.elementary-camera
  • pantheon.elementary-capnet-assist
  • pantheon.elementary-code
  • pantheon.elementary-dock
  • pantheon.elementary-feedback
  • pantheon.elementary-files
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-mail
  • pantheon.elementary-music
  • pantheon.elementary-notifications
  • pantheon.elementary-onboarding
  • pantheon.elementary-photos
  • pantheon.elementary-screenshot
  • pantheon.elementary-session-settings
  • pantheon.elementary-settings-daemon
  • pantheon.elementary-shortcut-overlay
  • pantheon.elementary-tasks
  • pantheon.elementary-terminal
  • pantheon.elementary-videos
  • pantheon.epiphany
  • pantheon.evince
  • pantheon.gala
  • pantheon.granite
  • pantheon.notes-up
  • pantheon.pantheon-agent-polkit
  • pantheon.sideload
  • pantheon.switchboard
  • pantheon.switchboard-plug-a11y
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-applications
  • pantheon.switchboard-plug-bluetooth
  • pantheon.switchboard-plug-datetime
  • pantheon.switchboard-plug-display
  • pantheon.switchboard-plug-keyboard
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-network
  • pantheon.switchboard-plug-notifications
  • pantheon.switchboard-plug-onlineaccounts
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-printers
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-plug-sharing
  • pantheon.switchboard-plug-sound
  • pantheon.switchboard-plug-wacom
  • pantheon.switchboard-with-plugs
  • pantheon.touchegg
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-a11y
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators
  • ping
  • regextester
  • sequeler
  • snippetpixie
  • spice-up
  • taxi
  • tootle
  • torrential
  • touchegg
  • vocal
  • xdg-desktop-portal-pantheon

@ofborg test pantheon

@bobby285271 bobby285271 marked this pull request as ready for review October 27, 2021 03:53
@ofborg ofborg bot requested review from dasj19, amaxine, jtojnar and hedning October 27, 2021 06:19
@bobby285271 bobby285271 merged commit 8e440f1 into NixOS:master Oct 28, 2021
@bobby285271 bobby285271 deleted the pantheon branch October 28, 2021 00:16
@bobby285271 bobby285271 mentioned this pull request Oct 28, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak Awaiting requested review from davidak

@dtzWill dtzWill Awaiting requested review from dtzWill

@dasj19 dasj19 Awaiting requested review from dasj19

@amaxine amaxine Awaiting requested review from amaxine

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
Pantheon
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobby285271 @jtojnar @davidak