pythonPackages.promnesia: init at 1.1.20230129 #215228

qbit · 2023-02-08T01:38:30Z

This add promnesia and its dependencies.

There are a few things I am not sure about:

HPI should be installing $out/bin/hpi, but it doesn't seem to be doing so.
promnesia runs a config.py configuration that users create / modify. Currently, that config.py fails to load HPI (lib is named my) and the promnesia lib when commands like promnesia doctor are used.

CC @mweinelt

mweinelt

First pass. A few changes that are required on all packages:

We require running tests, when they're available
- if not available on pypi, we fetch from the git source
We require explicit nativeCheckInputs, usually pytestCheckHook or unittestCheckHook
We require a format set just below version
- pyproject.toml? then pyproject
- setup.py? setuptools
The fetcher should use hash, not the legacy sha256 attribute

mweinelt · 2023-02-08T01:54:35Z

pkgs/development/python-modules/cachew/default.nix

@@ -0,0 +1,25 @@
+{ buildPythonPackage, fetchPypi, lib, appdirs, sqlalchemy, setuptools-scm }:


One argument per line, please.

mweinelt · 2023-02-08T01:55:53Z

pkgs/development/python-modules/cachew/default.nix

+
+buildPythonPackage rec {
+  pname = "cachew";
+  version = "0.11.0";


Suggested change

version = "0.11.0";

version = "0.11.0";

format = "setuptools";

We set an explicit format for python packages. This package uses a setup.py, so it is setuptools.

mweinelt · 2023-02-08T01:57:27Z

pkgs/development/python-modules/cachew/default.nix

+  src = fetchPypi {
+    inherit pname version;
+    sha256 = "sha256-4qjgvffInKRpKST9xbwwC2+m8h3ups0ZePyJLUU+KhA=";
+  };


Move the src below version and format.

Also did you notice that the pypi sdist does not contain tests? We should fetch from GitHub I think.

cachew> running test cachew> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. cachew> running egg_info cachew> writing src/cachew.egg-info/PKG-INFO cachew> writing dependency_links to src/cachew.egg-info/dependency_links.txt cachew> writing requirements to src/cachew.egg-info/requires.txt cachew> writing top-level names to src/cachew.egg-info/top_level.txt cachew> reading manifest file 'src/cachew.egg-info/SOURCES.txt' cachew> adding license file 'LICENSE.txt' cachew> writing manifest file 'src/cachew.egg-info/SOURCES.txt' cachew> running build_ext cachew> cachew> ---------------------------------------------------------------------- cachew> Ran 0 tests in 0.000s cachew> cachew> OK cachew> Finished executing setuptoolsCheckPhase

Also tests are run implicitly, which is deprecated. The project uses pytest, and we can use pytestCheckHook in checkInputs after updating the src.

mweinelt · 2023-02-08T01:58:45Z

pkgs/development/python-modules/HPI/default.nix

+}:
+
+buildPythonPackage rec {
+  pname = "HPI";


The pname and attribute need to be normalized according to PEP0503. In this case that means lowercasing them.

mweinelt · 2023-02-08T02:00:29Z

pkgs/development/python-modules/HPI/default.nix

+    sha256 = "sha256-cozMmfBF7D1qCZFjf48wRQaeN4MhdHAAxS8tGp/krK8=";
+  };
+
+  nativeBuildInputs = [ setuptools-scm ];


Suggested change

nativeBuildInputs = [ setuptools-scm ];

nativeBuildInputs = [

setuptools-scm

];

In python-modules we do expand all lists.

mweinelt · 2023-02-08T02:08:38Z

pkgs/development/python-modules/promnesia/default.nix

+
+  meta = with lib; {
+    homepage = "https://github.com/karlicoss/promnesia";
+    description = "Another piece of your extended mind";


While that description is what upstream is offering it is rather meaningless.

mweinelt · 2023-02-08T02:11:17Z

pkgs/development/python-modules/promnesia/default.nix

+}:
+
+buildPythonPackage rec {
+  pname = "promnesia";


Is this a library or an application? We only keep libraries in python-modules. Application need to be moved elsewhere.

It's both as far as I can tell - not sure how that changes the rules (if at all).. There is the command promnesia, but the configuration uses it as a library: https://github.com/karlicoss/promnesia/blob/master/src/promnesia/misc/config_example.py

Maybe it's both?

mweinelt · 2023-02-08T02:11:39Z

pkgs/development/python-modules/promnesia/default.nix

+  propagatedBuildInputs = [
+    beautifulsoup4
+    cachew
+    fastapi
+    HPI
+    httptools
+    logzero
+    lxml
+    mistletoe
+    more-itertools
+    mypy
+    orgparse
+    pytz
+    setuptools
+    sqlcipher3
+    tzlocal
+    urlextract
+    uvicorn
+    uvloop
+    watchfiles
+    websockets
+  ];


Separate out optional dependencies.

https://github.com/karlicoss/promnesia/blob/master/setup.py#L85

Then we also remove the linting dependencies which do not belong to propagatedBuildInputs

mweinelt · 2023-02-08T02:15:19Z

pkgs/top-level/python-packages.nix

@@ -4376,6 +4378,8 @@ self: super: with self; {

  hpccm = callPackage ../development/python-modules/hpccm { };

+  HPI = callPackage ../development/python-modules/HPI { };


Suggested change

HPI = callPackage ../development/python-modules/HPI { };

hpi = callPackage ../development/python-modules/hpi { };

mweinelt · 2023-02-08T02:15:43Z

pkgs/development/python-modules/orgparse/default.nix

+  doCheck = true;
+
+  meta = with lib; {
+    description = "";


Missing description

The description that upstream uses is "Emacs org-mode parser in Python":

Suggested change

description = "";

description = "Emacs org-mode parser in Python";

mweinelt · 2023-02-08T13:10:06Z

On 08.02.23 14:06, Aaron Bieber wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In pkgs/development/python-modules/promnesia/default.nix <#215228 (comment)>: > +, mypy +, orgparse +, pytz +, setuptools +, setuptools-scm +, sqlcipher3 +, tzlocal +, urlextract +, uvicorn +, uvloop +, watchfiles +, websockets +}: + +buildPythonPackage rec { + pname = "promnesia"; It's both as far as I can tell - not sure how that changes the rules (if at all).. There is the command |promnesia|, but the configuration uses it as a library: https://github.com/karlicoss/promnesia/blob/master/src/promnesia/misc/config_example.py <https://github.com/karlicoss/promnesia/blob/master/src/promnesia/misc/config_example.py> Maybe it's both? — Reply to this email directly, view it on GitHub <#215228 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABAED32OPJ6V325VVMP7BLWWOK5TANCNFSM6AAAAAAUUVHGDM>. You are receiving this because you were mentioned.Message ID: ***@***.***>

If it exposes some library front end it can stay in python-modules, but you likely also want to expose it with `toPythonApplication` in top-level/all-packages.nix.

SuperSandro2000 · 2023-02-08T14:19:40Z

pkgs/development/python-modules/cachew/default.nix

+    description =
+      "Transparent and persistent cache/serialization powered by type hints";


Suggested change

description =

"Transparent and persistent cache/serialization powered by type hints";

description = "Transparent and persistent cache/serialization powered by type hints";

I am going to set this project asside for a bit..

tomodachi94 · 2023-05-29T05:36:48Z

@qbit any updates on this?

qbit · 2023-05-29T18:53:00Z

@qbit any updates on this?

I gave up after being (iirc) 10 new deps deep. There are also some issues upstream(s) are sorting out: pudo/dataset#415

tomodachi94 · 2023-05-29T20:49:40Z

@qbit do you have a list of packages that need to be created? I'm willing to help take care of some of them.

EDIT: Also, there is a way to apply patches. See this file for an example of how to do that.

qbit · 2023-05-30T02:33:48Z

IIRC the last commit had all of the deps that were needed for functionality - but they are missing the test deps (and probably other test deps)

tomodachi94 · 2023-05-30T02:49:59Z

Ah, okay. This PR might merge a little faster if you split out some of the dependencies into other PRs. There are a few packages in here that don't have any issues and are probably ready for merge.

Feel free to tag me on any PRs related to this.

qbit added 5 commits February 7, 2023 18:21

pythonPackages.cachew: init at 0.11.0

1d25b06

pythonPackages.HPI: init at 0.0.20200417

6fba6b0

pythonPackages.orgparse init at 0.3.2

adcbd2a

pythonPackages.sqlcipher3: init at 0.5.0

7e16996

pythonPackages.promnesia: init at 1.1.20230129

a96c7c5

qbit requested review from FRidh and jonringer as code owners February 8, 2023 01:38

github-actions bot added the 6.topic: python label Feb 8, 2023

qbit marked this pull request as draft February 8, 2023 01:38

qbit changed the title ~~Draft: pythonPackages.promnesia: init at 1.1.20230129~~ pythonPackages.promnesia: init at 1.1.20230129 Feb 8, 2023

remove trailing white space

64817a5

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 8, 2023

mweinelt requested changes Feb 8, 2023

View reviewed changes

SuperSandro2000 reviewed Feb 8, 2023

View reviewed changes

bulk add the rest of the deps

31a85cd

I am going to set this project asside for a bit..

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 15, 2023

wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.promnesia: init at 1.1.20230129 #215228

pythonPackages.promnesia: init at 1.1.20230129 #215228

qbit commented Feb 8, 2023 •

edited

Loading

mweinelt left a comment

mweinelt Feb 8, 2023

mweinelt Feb 8, 2023

mweinelt Feb 8, 2023

mweinelt Feb 8, 2023

mweinelt Feb 8, 2023

mweinelt Feb 8, 2023

mweinelt Feb 8, 2023

qbit Feb 8, 2023

mweinelt Feb 8, 2023

SuperSandro2000 Feb 8, 2023

mweinelt Feb 8, 2023 •

edited by SuperSandro2000

Loading

mweinelt Feb 8, 2023

tomodachi94 May 29, 2023

mweinelt commented Feb 8, 2023 via email

SuperSandro2000 Feb 8, 2023

tomodachi94 commented May 29, 2023

qbit commented May 29, 2023

tomodachi94 commented May 29, 2023 •

edited

Loading

qbit commented May 30, 2023

tomodachi94 commented May 30, 2023 •

edited

Loading

		@@ -0,0 +1,25 @@
		{ buildPythonPackage, fetchPypi, lib, appdirs, sqlalchemy, setuptools-scm }:

	version = "0.11.0";
	version = "0.11.0";
	format = "setuptools";

		@@ -4376,6 +4378,8 @@ self: super: with self; {

		hpccm = callPackage ../development/python-modules/hpccm { };

		HPI = callPackage ../development/python-modules/HPI { };

	description = "";
	description = "Emacs org-mode parser in Python";

		description =
		"Transparent and persistent cache/serialization powered by type hints";

	description =
	"Transparent and persistent cache/serialization powered by type hints";
	description = "Transparent and persistent cache/serialization powered by type hints";

pythonPackages.promnesia: init at 1.1.20230129 #215228

Are you sure you want to change the base?

pythonPackages.promnesia: init at 1.1.20230129 #215228

Conversation

qbit commented Feb 8, 2023 • edited Loading

mweinelt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mweinelt Feb 8, 2023 • edited by SuperSandro2000 Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mweinelt commented Feb 8, 2023 via email

Choose a reason for hiding this comment

tomodachi94 commented May 29, 2023

qbit commented May 29, 2023

tomodachi94 commented May 29, 2023 • edited Loading

qbit commented May 30, 2023

tomodachi94 commented May 30, 2023 • edited Loading

qbit commented Feb 8, 2023 •

edited

Loading

mweinelt Feb 8, 2023 •

edited by SuperSandro2000

Loading

tomodachi94 commented May 29, 2023 •

edited

Loading

tomodachi94 commented May 30, 2023 •

edited

Loading