Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: Use ruby 2.7 #228850

Closed
wants to merge 1 commit into from

Conversation

ElvishJerricco
Copy link
Contributor

Description of changes

If anyone knows ruby things better than I do, let me know if there's a better way. But since 8826b55, vagrant no longer builds.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kirillrdy
Copy link
Member

#225136 this builds with ruby 3.1

@ElvishJerricco
Copy link
Contributor Author

So it does.

@ElvishJerricco ElvishJerricco mentioned this pull request May 1, 2023
12 tasks
@bjornfor bjornfor reopened this May 1, 2023
@bjornfor
Copy link
Contributor

bjornfor commented May 1, 2023

I tried to update the commit message, but failed to push.

vagrant: Use ruby 2.7

Because vagrant fails to build with ruby 3.1.

Fixes: 8826b550a0d5 ("ruby: update default version to `ruby_3_1`")

@bjornfor
Copy link
Contributor

bjornfor commented May 1, 2023

#225136 was merged instead.

@bjornfor bjornfor closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants