workflows/check-by-name: Better error when base branch also fails #257735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
check-by-name-base
branch
from
23238cd
to
124d15c
Compare
roberth
reviewed
Sep 28, 2023
infinisil
force-pushed
the
check-by-name-base
branch
2 times, most recently
from
84f162a
to
6e5e814
Compare
|
@roberth @RonnyPfannschmidt Now added a github workflow summary! |
Previously, even if the check also failed on the base branch, it looked like the PR introduced the failure. We can easily have a better error message for such cases. Meanwhile this also paves the road for something like NixOS#256788
infinisil
force-pushed
the
check-by-name-base
branch
from
6e5e814
to
0dcdf60
Compare
roberth
approved these changes
Oct 3, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-03-nixpkgs-architecture-team-meeting-44/33798/1 |
3 tasks
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously, even if the check also failed on the base branch, it would look like the PR introduced the failure (though I don't think this even happened).
We can have a better error message for such cases by also running the tool on the base branch, which is achievable with little extra effort.
However the main motivation really is that this paves the road towards #256788.
Note that due to using
pull_request_targetinstead ofpull_request, this PR itself does not trigger the new workflow.Things done