fennel-ls: init at 0.1.0 #281653
fennel-ls: init at 0.1.0 #281653
Conversation
There was a problem hiding this comment.
Here's a few suggestions!
Also, I think you need to rename the commit to fennel-ls: init at 0.1.0, to be consistent with the commit conventions
@yisraeldov Maybe also rename this PR's title to "fennel-ls: init at 0.1.0"? |
|
Could you move the commits around and rebase a bit to make it look like this? It's important that you add yourself to the maintainer list in the commit before the commit with the package. It might be a good idea to mark the PR as draft if you're unsure if you've rebased correctly. A wrong rebase can lead to pinging a lot of people. |
yisraeldov
force-pushed
the
fennel-ls
branch
2 times, most recently
from
224866f
to
85ab5f8
Compare
|
@yisraeldov Looks like you accidentally pulled in an extra commit during the rebase. |
fennel-ls: init at 0.1.0 add fennel-ls package Update pkgs/development/tools/language-servers/fennel-ls/default.nix Co-authored-by: h7x4 <[email protected]> Update pkgs/development/tools/language-servers/fennel-ls/default.nix Co-authored-by: h7x4 <[email protected]> Update pkgs/development/tools/language-servers/fennel-ls/default.nix Co-authored-by: h7x4 <[email protected]> Update pkgs/development/tools/language-servers/fennel-ls/default.nix Co-authored-by: h7x4 <[email protected]> Update pkgs/development/tools/language-servers/fennel-ls/default.nix Co-authored-by: h7x4 <[email protected]> Update pkgs/development/tools/language-servers/fennel-ls/default.nix Co-authored-by: h7x4 <[email protected]> fixes from code review switch to 'by-name'
You are right, thanks, fixed |
|
Feel free to mark your PR as ready for review again, since the rebase went smooth 👍 |
Description of changes
Add package fennel-ls
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.