fido2luks: move to by-name & fix build

[quantenzitrone]

Description of changes

fixes #288865

I don't have a device that works with fido2luks so i can't test if it works, but it builds now at least.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[quantenzitrone]

Result of nixpkgs-review pr 297238 run on x86_64-linux 1

1 package built:

• fido2luks

[quantenzitrone]

I can't test the fix for the nixosTest, but I managed to reproduce the issue on x86_64-linux by adding another USB controller with the wrong speed.
So I now specifically specify the CanoKey to use the usb-bus.0 bus which is controlled by the UHCI Controller which has the same speed as CanoKey ("full speed").
https://qemu-project.gitlab.io/qemu/system/devices/usb.html#ehci-controller-support

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3655

[quantenzitrone]

wait the systemd fido2 support has nothing to do with fido2luks
sorry

[quantenzitrone]

I couldn't get my Nitrokey 3C NFC to work with fido2luks, so maybe I should remove the fix for nitrokeys. On the other hand, fido2luks is at least able to detect fido2 tokens using the nitrokey firmware, which is a slight improvement.

fixed