Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.fpdf2: disable failing tests #309846

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

josephst
Copy link
Member

@josephst josephst commented May 7, 2024

Description of changes

Fixes/ works around #308941 - two tests are disabled which try to download a file, as well as an additional JPEG2000 test which is failing for unclear reasons.

Part of Zero Hydra Failures #309482

Still has some build failures on packages that were failing prior to this patch as well - these appear to be broken upstream, including:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • Note: some packages (python3.12-docformatter-1.7.5, python3.12-certomancer-0.11.0, and python3.12-comicon-1.0.1/python3.11-comicon-1.0.1) broken, but they appear to have been broken before this change as well.
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Full nixpkgs-review log:

...
┣━ Dependency Graph:
┃             ┌─ ⚠ python3.12-docformatter-1.7.5 failed with exit code 1 after ⏱ 2s in pytestCheckPhase
┃          ┌─ ⏸ python3.12-xsdata-24.2.1
┃          ├─ ⚠ python3.12-certomancer-0.11.0 failed with exit code 1 after ⏱ 9s in pytestCheckPhase
┃       ┌─ ⏸ python3.12-pyhanko-0.21.0
┃    ┌─ ⏸ python3.12-xhtml2pdf-0.2.15
┃    ├─ ⏸ python3.12-mandown-1.7.0 waiting for 1 ⚠
┃    ├─ ⏸ python3.11-mandown-1.7.0 waiting for 1 ⚠
┃    ├─ ⏸ python3.11-mandown-1.7.0 waiting for 1 ⚠
┃    ├─ ⚠ python3.12-comicon-1.0.1 failed with exit code 1 after ⏱ 0s in pythonRuntimeDepsCheckHook
┃    ├─ ⚠ python3.11-comicon-1.0.1 failed with exit code 1 after ⏱ 0s in pythonRuntimeDepsCheckHook
┃ ┌─ ⏸ env
┃ ⏸ review-shell
┣━━━ Builds
┗━ ∑ ⏵ 0 │ ✔ 0 │ ⏸ 8 │ ⚠ Exited after 4 build failures at 09:19:40 after 16s
12 packages failed to build:
comic-mandown comic-mandown.dist python311Packages.comicon python311Packages.comicon.dist python311Packages.mandown python311Packages.mandown.dist python312Packages.comicon python312Packages.comicon.dist python312Packages.mandown python312Packages.mandown.dist python312Packages.xhtml2pdf python312Packages.xhtml2pdf.dist

48 packages built:
calibre-web calibre-web.dist diffoscope diffoscope.dist diffoscope.man diffoscopeMinimal diffoscopeMinimal.dist diffoscopeMinimal.man maigret maigret.dist mdbook-pdf-outline mdbook-pdf-outline.dist pretix pretix.dist python311Packages.camelot python311Packages.camelot.dist python311Packages.clarifai python311Packages.clarifai.dist python311Packages.fpdf2 python311Packages.fpdf2.dist python311Packages.llama-index python311Packages.llama-index-readers-file python311Packages.llama-index-readers-file.dist python311Packages.llama-index-readers-s3 python311Packages.llama-index-readers-s3.dist python311Packages.llama-index.dist python311Packages.pypdf python311Packages.pypdf.dist python311Packages.pypdf.doc python311Packages.xhtml2pdf python311Packages.xhtml2pdf.dist python312Packages.camelot python312Packages.camelot.dist python312Packages.clarifai python312Packages.clarifai.dist python312Packages.fpdf2 python312Packages.fpdf2.dist python312Packages.llama-index python312Packages.llama-index-readers-file python312Packages.llama-index-readers-file.dist python312Packages.llama-index-readers-s3 python312Packages.llama-index-readers-s3.dist python312Packages.llama-index.dist python312Packages.pypdf python312Packages.pypdf.dist python312Packages.pypdf.doc sasview sasview.dist

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from jfvillablanca May 7, 2024 14:40
@josephst josephst added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 7, 2024
@jfvillablanca
Copy link
Member

Result of nixpkgs-review pr 309846 run on x86_64-linux 1

12 packages failed to build:
  • comic-mandown
  • comic-mandown.dist
  • python311Packages.comicon
  • python311Packages.comicon.dist
  • python311Packages.mandown
  • python311Packages.mandown.dist
  • python312Packages.comicon
  • python312Packages.comicon.dist
  • python312Packages.mandown
  • python312Packages.mandown.dist
  • python312Packages.xhtml2pdf
  • python312Packages.xhtml2pdf.dist
48 packages built:
  • calibre-web
  • calibre-web.dist
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • diffoscopeMinimal
  • diffoscopeMinimal.dist
  • diffoscopeMinimal.man
  • maigret
  • maigret.dist
  • mdbook-pdf-outline
  • mdbook-pdf-outline.dist
  • pretix
  • pretix.dist
  • python311Packages.camelot
  • python311Packages.camelot.dist
  • python311Packages.clarifai
  • python311Packages.clarifai.dist
  • python311Packages.fpdf2
  • python311Packages.fpdf2.dist
  • python311Packages.llama-index
  • python311Packages.llama-index-readers-file
  • python311Packages.llama-index-readers-file.dist
  • python311Packages.llama-index-readers-s3
  • python311Packages.llama-index-readers-s3.dist
  • python311Packages.llama-index.dist
  • python311Packages.pypdf
  • python311Packages.pypdf.dist
  • python311Packages.pypdf.doc
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • python312Packages.camelot
  • python312Packages.camelot.dist
  • python312Packages.clarifai
  • python312Packages.clarifai.dist
  • python312Packages.fpdf2
  • python312Packages.fpdf2.dist
  • python312Packages.llama-index
  • python312Packages.llama-index-readers-file
  • python312Packages.llama-index-readers-file.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.llama-index.dist
  • python312Packages.pypdf
  • python312Packages.pypdf.dist
  • python312Packages.pypdf.doc
  • sasview
  • sasview.dist

@wegank wegank changed the title disable failing tests on fpdf2 python311Packages.fpdf2: disable failing tests May 8, 2024
@wegank wegank merged commit dfd8445 into NixOS:master May 8, 2024
25 checks passed
@josephst josephst deleted the fix/fpdf2 branch May 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants