bash-kernel: fix and add smoke test

[thomasjm]

Description of changes

The bash-kernel in Nixpkgs is currently broken due to takluyver/bash_kernel#142.

The underlying issue is that bash-kernel uses invisible characters in its prompt, which are currently not being output.

This PR fixes it by using bashInteractive instead of bash. I don't totally understand why this fix works--AFAICT, the main difference between the two is that bashInteractive has the readline library included. In any case, using bashInteractive is probably closer to how most people use bash-kernel, as it just runs whatever bash is on the PATH.

This PR also adds a smoke test, in the form of a test notebook that gets evaluated by Papermill. If this succeeds, we know basic kernel evaluation works.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

CC @zimbatm @teto

[teto]

Haven't tested.

[teto]

so this would fail without bashInteractive ?
I wonder if it should go through passtru.tests or in checkPhase since papermill becomes a new dependency ? without your fixes, the kernel still works but with a funky prompt ? (sry I read a bit fast)

[thomasjm]

The kernel is totally broken without bashInteractive. It crashes right away with an error about being unable to parse the prompt.

I don't know about the current best practices regarding passthru.tests. It seems like a good idea to always run a smoke check to prevent regressions like the one we currently have.

If we do the checkPhase option, Papermill would only be a build-time dependency right? So users getting it from the Nixpkgs cache wouldn't experience any change.