Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cctag: fix failing tests with gcc13 #311609

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented May 14, 2024

Since GCC13 the package does not build correctly, causing the tests to fail. This was not the case with GCC12. Instead of building it with an older version of GCC, we can build and test it successfully with Clang.

Description of changes

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Since GCC13 the package does not build correctly, causing the tests to
fail. This was not the case with GCC12. Instead of building it with an
older version of GCC, we can build and test it successfully with
Clang.
@josephst
Copy link
Member

Result of nixpkgs-review pr 311609 run on x86_64-linux 1

3 packages built:
  • cctag
  • cctag.dev
  • cctag.lib

@wegank wegank merged commit a423476 into NixOS:master May 15, 2024
29 checks passed
@jmpunkt jmpunkt deleted the fix-cctag-gcc13 branch May 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: cctag
3 participants