gradle: 8.7 → 8.8

[lorenzleutgeb]

Description of changes

https://docs.gradle.org/8.8/release-notes.html

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[lorenzleutgeb]

Result of nixpkgs-review run on x86_64-linux 1

5 packages failed to build:

• gscan2pdf
• gscan2pdf.man
• mindustry
• mindustry-server
• mindustry-wayland

33 packages built:

• apkleaks
• apkleaks.dist
• apksigcopier
• apksigcopier.dist
• apksigner
• cie-middleware-linux
• diffoscope
• diffoscope.dist
• diffoscope.man
• experienced-pixel-dungeon
• fdroidserver
• fdroidserver.dist
• ghidra-extensions.gnudisassembler
• ghidra-extensions.machinelearning
• ghidra-extensions.sleighdevtools
• gradle
• jabref
• jadx
• javaPackages.openjfx22
• jextract
• jextract-21
• kotlin-language-server
• moneydance
• pdf-sign
• pdfchain
• pdftk
• pidginPackages.purple-signald
• rat-king-adventure
• rkpd2
• shattered-pixel-dungeon
• shorter-pixel-dungeon
• signald
• signaturepdf

gscan2pdf.man.log
mindustry-wayland.log
mindustry-server.log
mindustry.log
gscan2pdf.log

[liff]

The Mindustry build failure needs to be addressed before merging, I suppose. Looks OK otherwise.

Can we get #277721 in before or after maybe? 😊

[lorenzleutgeb]

Yup, #277721 is overdue. I don't mind before or after, and am happy to rebase this if required.

[fgaz]

The Mindustry build failure needs to be addressed before merging, I suppose.

Until Anuken/Arc#169 is fixed we can switch to gradle_7 which still works

[C0D3-M4513R]

It would be nice to get this in, as currently we have jdk22 in nixos but no gradle, that supports jdk22 properly.

Full support for jdk22 in gradle was only added in gradle 8.8.

(I discovered that in Col-E/Recaf#805)

[fgaz]

Until Anuken/Arc#169 is fixed we can switch to gradle_7 which still works

Now there is also a patch: Anuken/Arc@d7f8ea8

[lorenzleutgeb]

@fgaz sure, but how long will it take until there is a new release of Mindustry that depends on a patched version of Arc and you found time to bump pkgs.mindustry? Months? I'd rather ask for you to pin gradle = pkgs.gradle_7 in pkgs.mindustry in the meantime, which I expect to be a simple change. Thanks!

[JohnRTitor]

LGTM

[SuperSandro2000]

Months? I'd rather ask for you to pin gradle = pkgs.gradle_7 in pkgs.mindustry in the meantime, which I expect to be a simple change. Thanks!

This should have been added to this PR

#323389